zulip-desktop
zulip-desktop copied to clipboard
zulip
BrowserView: Updated, rebased PR with bug fixes.
What's this PR do?
Same purpose as #793, but updated to pass tests and include more recent features.
For code to pass compilation, we may have to modify electron.d.ts to the file here.
I needed to make the above changes so that page-title-updated would be counted as a before-input-event.
You have tested this PR on:
- [x] Windows
- [ ] Linux/Ubuntu
- [ ] macOS
@kanishk98 is this good to merge? If yes, then I'll need to cross-check the auto-update before merging.
Yeah, features and settings seem to be working pretty well for me. I'll do another check just to make sure, but I think it's good to be merged.
Please also text me on czo if you need any help with testing the auto-update process.
Okay, great. I'm testing the auto-update on macOS first. Can you do the same on Linux?
Can you do the same on Linux?
I can test it out on Windows (will let you know the results on czo). @muskankhedia would you mind testing this on Linux? I'll walk you through the process.
I've fixed the merge conflicts and also updated the broken link to the modified electron.d.ts file required.
@akashnimare please have a look at this and let me know if it's good to go.
@muskankhedia can you try running the auto-update on Windows and/or Linux and let us know how that goes? I'm getting the "Windows is unable to find Zulip.exe" error on my system, which is not related to the auto-update.
@vsvipul hey, good to see you back :)
This is next in our roadmap. I'm releasing the stable release from the master, once done we can push a beta release with this PR.
Heads up @kanishk98, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/master branch and resolve your pull request's merge conflicts accordingly.
