zulip-desktop
zulip-desktop copied to clipboard
zulip
Add URL copy/paster to left sidebar
What's this PR do?
Adds a URL container to the left sidebar that displays the URL of the active organization and copies it to the clipboard automatically. Entering a URL into the container makes the app check if the domain is already saved and then switch to the relevant tab if that's the case.
Any background context you want to provide?
Check out #578 for the same.
Screenshots?
Possible improvements #578 shows a suggestion for a copy button. I couldn't design it as intended (inside the input field), and I think it could make for a nice improvement.
You have tested this PR on:
- [x] Windows
- [ ] Linux/Ubuntu
- [ ] macOS
@kanishk98 Is the copying limited to just the server name or does it also show the topic or stream part? While pasting does it go to the the narrow view if we paste a link of a narrow or just focuses on the correct org?
Is the copying limited to just the server name or does it also show the topic or stream part?
It's limited to the server URL only.
While pasting does it go to the the narrow view if we paste a link of a narrow or just focuses on the correct org?
There's no web-based stuff involved here. So it'll simply change tabs to another server if the URL of an already saved URL is pasted into the field.
Currently, if a URL belonging to a server that has not been saved is pasted into the field, the app doesn't do anything. I didn't want to add an indication without a discussion. @abhigyank what do you think we should do in that case? Simply clear the field?
It's limited to the server URL only.
Okay, understood. I am not sure if that servers us much purpose here, I mean the chances of someone pasting chat.zulip.org in a toolbar to open the issue would be a very rare case I suppose, unless someone has like 20-30 added organizations (again a very very rare case, max I have seen is about 12). Typically the use case would be as mentioned in the issue would be to narrow into a view after pasting an url, since it would help people directly opening links from browser or emails (this needs to be done very very carefully as can lead to attacks).
if a URL belonging to a server that has not been saved is pasted into the field, the app doesn't do anything.
This can simple like showing a red exclamation icon or a red boundary - something that websites do to show incorrect passwords dynamically.
Typically the use case would be as mentioned in the issue would be to narrow into a view after pasting an url, since it would help people directly opening links from browser or emails (this needs to be done very very carefully as can lead to attacks).
Alright, I understand. I'll be addressing both #470 and this together since they're somewhat similar. Will get to it after my proposal submission, if that's okay.
This can simple like showing a red exclamation icon or a red boundary - something that websites do to show incorrect passwords dynamically.
Easy enough. I'll do this as soon as I can. Thanks for the review.
This can simple like showing a red exclamation icon or a red boundary - something that websites do to show incorrect passwords dynamically.
Done and pushed. Works as shown below.
I've already implemented the desired redirection in #716. I think I should wait for a proper review on that before using the same logic here. We can just merge both of them then.
Heads up @kanishk98, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/master branch and resolve your pull request's merge conflicts accordingly.
