zulip-desktop icon indicating copy to clipboard operation
zulip-desktop copied to clipboard

Published 20 hours ago • verified publisher icon zulip

Broken back and forward

Open punchagan opened this issue 6 years ago • 13 comments

Looks like Alt + Left and Alt + Forward don't work on master. This seems to have been introduced with updating to Electron v3.

punchagan avatar Feb 12 '19 08:02 punchagan

Seem to be working on for me in the latest master on Ubuntu.

abhigyank avatar Feb 12 '19 10:02 abhigyank

Doesn't seem to be a problem in the latest master on Windows 10 either. :) @punchagan what Linux distro are you running?

kanishk98 avatar Feb 12 '19 12:02 kanishk98

@punchagan what Linux distro are you running?

Ubuntu 18.10; Gnome Shell. @akashnimare was able to reproduce it on Mac OS as well.

Have you run npm install before running npm start ?

punchagan avatar Feb 12 '19 14:02 punchagan

Have you run npm install before running npm start ?

I did, I'm running Electron 4.1.4 and unable to see either the keyboard shortcut failure or the inactivity of the back button from settings.

kanishk98 avatar Apr 07 '19 12:04 kanishk98

This happens sometime but can't reproduce frequently. @punchagan can you?

akashnimare avatar Apr 07 '19 12:04 akashnimare

Yeah, it's not reliably reproducible for me either.

punchagan avatar Apr 07 '19 18:04 punchagan

@akashnimare @kanishk98 Back is not working when someone goes to setting and then try to go back to the organization. But it works fine inside the organization. I think for the problem in the broken back for setting, we can store the organization into a variable and fetch it when it's required. [Tested on macOS]

adityamudgil2505 avatar Mar 10 '20 20:03 adityamudgil2505

@adityamudgil2505 can you open a WIP PR with your fix?

akashnimare avatar Mar 11 '20 07:03 akashnimare

@zulipbot claim

adityamudgil2505 avatar Mar 11 '20 18:03 adityamudgil2505

Hello @adityamudgil2505, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

zulipbot avatar Mar 21 '20 22:03 zulipbot

@zulipbot claim

textjai-16 avatar Feb 29 '24 17:02 textjai-16

Welcome to Zulip, @textjai-16! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-desktop/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

zulipbot avatar Feb 29 '24 17:02 zulipbot

@textjai-16 You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

zulipbot avatar Mar 10 '24 19:03 zulipbot