zulip-desktop icon indicating copy to clipboard operation
zulip-desktop copied to clipboard

Add a feature to configure DND mode

Open akashnimare opened this issue 6 years ago • 13 comments

We have a basic DND feature in the left sidebar which activates the DND mode and to deactivate user need to update it manually. It would be great to have something like -

  • Enable DND mode for X minutes/hrs/day

and then automatically handles the notification setting after the DND time gets over.

Two things we need to do here - a) UI/UX - I think we can show the time within the tooltip itself b) How to calculate the DND time since there could be multiple cases like the laptop is switched off/sleep etc.

image

akashnimare avatar Sep 15 '18 07:09 akashnimare

To implement this I have/had a rough plan in mind:

  • First we should create the UX/UI in a new branch or that only shows up in development mode.

  • Then, once we have the UI, we can set up the turn on/off thing per input provided by the user.

  • Lastly, we should save in JsonDB the end-time of DND time, so it just a one if statement on the start of the app to turn it off or schedule a timer if it not done yet.

For step two, we can use something like node-schedule to do turn off the DND button after the specified time, in which case if the app is closed or device shut-down it will not work. Which we will need to cover in step three.

priyank-p avatar Sep 15 '18 15:09 priyank-p

I know this is the repository for the electron app, but can you clarify why you see DND as an app setting rather than a profile-setting? Imho it leads to confusion and unwanted behaviour if there is a DND layer above a profile setting. If I don't want to be disturbed, then I do so in my online status which should then reflect across all apps.

similarly if i want to receive notifications again, I should be able to do so on mobile and the changes should reflect on desktop. that's why I think this should be followed further (only) as a profile setting and not as an app setting.

lukasIO avatar Sep 15 '18 20:09 lukasIO

@lukasIO please see the relevant conversations here - https://chat.zulip.org/#narrow/stream/16-desktop/topic/DND.20button

akashnimare avatar Sep 17 '18 07:09 akashnimare

Thanks for the link. As it seems the main reasonis this statement by @timabbott

I think it's actually probably useful to have a desktop app feature for this, because if you're in multiple organizations, you kida want to be able to turn it off for all of them at once.

I agree that this is a very good point, which i didn't consider before. I would still prefer if this kind of status-change would reflect consistently over web, desktop and mobile. How to communicate over multiple organizations a common state - I have no idea. An approach to change an additonal notification-status in each logged in organization would be an option, maybe.

lukasIO avatar Sep 17 '18 07:09 lukasIO

For the webapp - https://github.com/zulip/zulip/issues/295

akashnimare avatar Sep 17 '18 09:09 akashnimare

For the UI thing, we could show something like this in the tooltip -

image

akashnimare avatar Sep 18 '18 14:09 akashnimare

@zulipbot claim

manavmehta avatar Mar 03 '20 16:03 manavmehta

Welcome to Zulip, @manavmehta! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-desktop/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

zulipbot avatar Mar 03 '20 16:03 zulipbot

Hello @manavmehta, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

zulipbot avatar Apr 01 '20 16:04 zulipbot

@zulipbot PR #896 has been made and is under review

manavmehta avatar Apr 01 '20 16:04 manavmehta

Is this still open? because on my machine i am unable to produce the time, as you have done in your PR(s) @akashnimare @manavmehta

varun-s22 avatar Jan 19 '23 13:01 varun-s22