zulip-desktop icon indicating copy to clipboard operation
zulip-desktop copied to clipboard

Published 20 hours ago • verified publisher icon zulip

Tray: unread messages icon fix for linux

Open Aitchessbee opened this issue 10 months ago • 5 comments

Fixes #1364

You have tested this PR on:

  • [ ] Windows
  • [x] Linux/Ubuntu
  • [ ] macOS

Aitchessbee avatar Mar 29 '24 15:03 Aitchessbee

So the issue was in the window.devicePixelRatio used in renderCanvas code (that is only being run for linux). window.devicePixelRatio takes the value of the scaling factor set on your linux PC, and if it's anything other than 1, the icon breaks... With the scaling factor set to 1 the icon stays the same size irrespective of the scaling factor, which also matches the other tray icons that I had (cloudinary and slack)...

Old - image

New - image

Aitchessbee avatar Mar 30 '24 05:03 Aitchessbee

Thanks for the fix! Could you please update your commit message to match the commit style guidelines?

Also, please add before/after screenshots to the PR description.

alya avatar Apr 01 '24 19:04 alya

Done! Let me know if there are any other changes...

Aitchessbee avatar Apr 08 '24 15:04 Aitchessbee

I've had this problem for a while, under both X11 and Wayland, using a 4K screen with my display scaled to 200%.

I wanted to confirm that the fix here works for me--thanks @Aitchessbee

image

Would love to see this PR included in the next release. Thanks for all the great work on Zulip!

mkaminsky avatar Aug 08 '24 21:08 mkaminsky

@andersk are you up for reviewing this proposed one-line change?

alya avatar Aug 27 '24 21:08 alya