zulip-desktop icon indicating copy to clipboard operation
zulip-desktop copied to clipboard

Published 20 hours ago • verified publisher icon zulip

Fixes #862: Improve reconnect error page.

Open enesonus opened this issue 1 year ago • 9 comments

What's this PR do? Fixed image scaling problem when resizing screen and buttons' position is aligned with texts at all possible window sizes.

Screenshots? ezgif-2-79b66698f3

You have tested this PR on:

  • [ ] Windows
  • [x] Linux/Ubuntu
  • [x] macOS

enesonus avatar Mar 31 '23 13:03 enesonus

@zulipbot claim

tarun-kanojia avatar Apr 05 '23 17:04 tarun-kanojia

Hello @tarun-kanojia!

Thanks for your interest in Zulip! You have attempted to claim an issue without the label "help wanted". You can only claim and submit pull requests for issues with the help wanted label.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

zulipbot avatar Apr 05 '23 17:04 zulipbot

@zulipbot add "good first issue"

tarun-kanojia avatar Apr 05 '23 17:04 tarun-kanojia

@zulipbot "help wanted"

tarun-kanojia avatar Apr 05 '23 17:04 tarun-kanojia

Hey @timabbott the issue seems to persist on the last version of Zulip. Can you please give a review on the changes I made?

enesonus avatar Aug 15 '23 16:08 enesonus

@zulipbot claim

mdaatifayman786 avatar Dec 30 '23 13:12 mdaatifayman786

Hello @mdaatifayman786!

Thanks for your interest in Zulip! You have attempted to claim an issue without the label "help wanted". You can only claim and submit pull requests for issues with the help wanted label.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

zulipbot avatar Dec 30 '23 13:12 zulipbot

Hi @timabbott this PR is currently up to date with the main and fixes #862 (seems to be still open) can you give a review please?

enesonus avatar Jan 27 '24 13:01 enesonus