zulip-desktop icon indicating copy to clipboard operation
zulip-desktop copied to clipboard

Padding added between the tooltip and the sidebar, Issue resolved, Fixes #1087

Open Dishti-Oberai opened this issue 3 years ago • 4 comments

Fixes #1087

This PR has added spacing between the tooltip and sidebar like tooltips of setting, reload, dnd and back button

All changes have been made in the main.css file in render folder in apps folder.

spacing between tooltip and sidebar image spacing between sidebar and tooltips of setting,reload,dnd and back button image Image of site image

This PR has been tested on

  • [x] Windows

Dishti-Oberai avatar Nov 10 '21 15:11 Dishti-Oberai

The changes look good to me, but the tests are failing. Understand what the test says, image

Instead of 0px, use 0 here.

Also, don't comment these. image Remove these lines if you don't want them in the PR.

Signior-X avatar Nov 20 '21 11:11 Signior-X

Thank you @Signior-X, I understood the error. Will look into it and make the necessary changes.

Dishti-Oberai avatar Nov 20 '21 12:11 Dishti-Oberai

Hello @Dishti-Oberai, it seems like you have referenced #1087 in your pull request description, but you have not referenced them in your commit message description(s). When you reference an issue in a commit message, it automatically closes the corresponding issue when the commit is merged.

Please run git commit --amend in your command line client to amend your commit message description with Fixes #1087..

An example of a correctly-formatted commit:

commit fabd5e450374c8dde65ec35f02140383940fe146
Author: zulipbot
Date:   Sat Mar 18 13:42:40 2017 -0700

    pull requests: Check PR commits reference when issue is referenced.

    Fixes #51.

Thank you for your contributions to Zulip!

zulipbot avatar Nov 20 '21 12:11 zulipbot

Heads up @Dishti-Oberai, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

zulipbot avatar Apr 09 '22 00:04 zulipbot