zulip-desktop icon indicating copy to clipboard operation
zulip-desktop copied to clipboard

No spacing between tooltips of organisations

Open Ayushsunny opened this issue 3 years ago • 5 comments


What's this PR do? Fixed spacing between the tooltip of organisation and the sidebar in #1087

Any background context you want to provide? Solved the issue without any conflicts.

Screenshots?

Before commit before

After commit

Screenshot from 2021-04-04 10-29-17

You have tested this PR on:

  • [ ] Windows
  • [x] Linux(Ubuntu 20.04 - Linux x86_64)
  • [ ] macOS

Ayushsunny avatar Apr 03 '21 22:04 Ayushsunny

Hello @timabbott , @andersk could you please review and merge ?

Ayushsunny avatar Apr 03 '21 22:04 Ayushsunny

This appears to be the same change as #1091. Please don’t close and open multiple PRs for the same change—update the existing PR instead.

Your commit message “Solved Conflict” gives no information at all about what you are changing and why. See our documentation for guidance on commit messages.

andersk avatar Apr 04 '21 00:04 andersk

Your commit message “Solved Conflict” gives no information at all about what you are changing and why. See our documentation for guidance on commit messages.

Sure, Sir, I will edit it.

Ayushsunny avatar Apr 04 '21 04:04 Ayushsunny

Heads up @Ayushsunny, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

zulipbot avatar Apr 09 '22 00:04 zulipbot

is this issue still pending?

Kamlesh72 avatar Oct 16 '22 08:10 Kamlesh72