zulip-desktop icon indicating copy to clipboard operation
zulip-desktop copied to clipboard

good first issue solved

Open yoBoyio opened this issue 3 years ago • 4 comments

This solves #1087 issue, spacing between tooltips of organisations. Tested on Ubuntu Zulip-Desktop Version 5.6.0

zulip_good_1st_issue

yoBoyio avatar Mar 24 '21 23:03 yoBoyio

Thanks for working on this @yoBoyio and welcome! This looks reasonable but needs a proper commit message.

Check out the Zulip commit message guidelines for more details: https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages

timabbott avatar Mar 25 '21 03:03 timabbott

Thanks for working on this @yoBoyio and welcome! This looks reasonable but needs a proper commit message.

Check out the Zulip commit message guidelines for more details: https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages

Hello @timabbott Sir, I have already made the PR earlier than him but you are considering his PR why sir? https://github.com/zulip/zulip-desktop/pull/1091#issue-598217060

Ayushsunny avatar Mar 25 '21 04:03 Ayushsunny

@timabbott Thank you for the details, can I try again?

yoBoyio avatar Mar 25 '21 09:03 yoBoyio

Heads up @yoBoyio, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

zulipbot avatar Apr 09 '22 00:04 zulipbot