zulip-desktop icon indicating copy to clipboard operation
zulip-desktop copied to clipboard

Published 20 hours ago • verified publisher icon zulip

Settings window should also have "Night Mode"

Open Ethanol6 opened this issue 4 years ago • 5 comments

Problem Description When the "Night mode" is selected through the menu, the settings window is still a light theme.

Proposed Solution The settings window should have a dark theme as well.

Describe alternatives you've considered Sunglasses :)

Additional context I am running Zulip 5.6.0 Desktop Appimage on Linux Mint 20.1

Ethanol6 avatar Feb 25 '21 05:02 Ethanol6

Structurally, the night theme setting is just for the Zulip webapp (aka for a particular organization), and can't be directly read/inherited by the app-level settings page (which are shared by all Zulip organizations).

We also would need to do CSS for the app-level settings to support this, though it's a simple enough site that it's probably not hard.

Do you spend much time in the app-level settings UI? I'm not sure how much work this would be to implement, but that'd at least give a sense as to the benefit.

timabbott avatar Mar 12 '21 09:03 timabbott

This is kind of a paper cut issue for me. It has a small effect on the user experience but tied in with a couple other issues it is fairly noticeable.

  • I do not spend that much time in the app-level settings. However, as per #1077, even with the sidebar visible it is not that easy to figure out how to exit the app-level settings quickly.

  • I also find it counter-intuitive that the Night mode setting is found in the organization settings and not the app-level settings. Since I want the app itself to be displayed with dark colours. I would expect night/day settings to be reflected throughout the whole app and not per organization.

  • Most of my attention is drawn to the left hand side of the app. The sidebar, the streams and the colourful topic labels on messages are on the left. It draws my eyes to the left side of the app, where the app-level settings icon is also located. I click on the app-level settings menu regardless of the setting I'm looking for before I remember the other settings menu icon is in the exact opposite corner and smaller and less noticeable too.

Considering all of that, I open the app-level settings more frequently than I want or need to.

Ethanol6 avatar Mar 13 '21 07:03 Ethanol6

Thanks, that feedback is helpful!

timabbott avatar Mar 16 '21 19:03 timabbott

can I work on this issue ? @zulipbot claim

r0nz-29 avatar Feb 08 '22 11:02 r0nz-29

Hello @r0nz-29!

Thanks for your interest in Zulip! You have attempted to claim an issue without the labels "help wanted", "good first issue". Since you're a new contributor, you can only claim and submit pull requests for issues with the help wanted or good first issue labels.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

zulipbot avatar Feb 08 '22 11:02 zulipbot