zulip-desktop icon indicating copy to clipboard operation
zulip-desktop copied to clipboard

Add ForwardButton to Sidebar

Open tarun8718 opened this issue 3 years ago • 5 comments

Signed-off-by: tarun8718 [email protected]


What's this PR do: Adds Forward Button to the sidebar.

Screenshots ForwardButton

You have tested this PR on:

  • [ ] Windows
  • [x] Linux/Ubuntu
  • [ ] macOS

tarun8718 avatar Feb 05 '21 13:02 tarun8718

Nice!

octogonz avatar Feb 05 '21 21:02 octogonz

@andersk could you please review this?

tarun8718 avatar Mar 10 '21 10:03 tarun8718

My first question is, why is this functionality so important as to justify taking away space on the sidebar that could be used for more organizations? Can you explain the use case?

andersk avatar Mar 10 '21 16:03 andersk

As a new user, it took me a while to realize that the -> command existed at all. It is not found next to the <- button. It is under the History menu (where the <- command has a different name "Back"). Working in a public OSS forum where the majority of our participants are using Zulip for the first time, I can say that Zulip is not very intuitive for new users. So if something is counterintuitive for myself after months of using Zulip, it's likely that new users would also be confused by this.

BTW the desktop app for Slack has both <- and -> buttons. They solve the problem you mentioned by putting their buttons in the title bar:

Capture

octogonz avatar Mar 10 '21 19:03 octogonz

Heads up @tarun8718, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

zulipbot avatar Nov 24 '21 02:11 zulipbot