zulip-desktop icon indicating copy to clipboard operation
zulip-desktop copied to clipboard

Migrate Windows CI from Appveyor to GitHub Actions

Open rht opened this issue 4 years ago • 21 comments

We'd want to have fewer CI platforms to keep track of. See also https://chat.zulip.org/#narrow/stream/16-desktop/topic/appveyor.20ci.

rht avatar Jan 19 '21 06:01 rht

@zulipbot claim

ganpa3 avatar Jan 19 '21 08:01 ganpa3

Hello @ganpa3!

Thanks for your interest in Zulip! You have attempted to claim an issue without the labels "help wanted", "good first issue". Since you're a new contributor, you can only claim and submit pull requests for issues with the help wanted or good first issue labels.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

zulipbot avatar Jan 19 '21 08:01 zulipbot

Much of the work is done in this PR: https://github.com/zulip/zulip-desktop/pull/901

ganpa3 avatar Jan 19 '21 09:01 ganpa3

@ganpa3 that PR is for app installer. The test procedure on appveyor.yml is different. You can still work on it.

rht avatar Jan 19 '21 11:01 rht

Oh, actually, that PR includes npm run test on windows-latest.

rht avatar Jan 19 '21 12:01 rht

Sounds like we should rebase/clean up #901, which seems to have been unfinished; I don't think the author has been active recently so someone else should take it up.

timabbott avatar Jan 26 '21 21:01 timabbott

@zulipbot claim

ganpa3 avatar Feb 05 '21 17:02 ganpa3

Hello @ganpa3!

Thanks for your interest in Zulip! You have attempted to claim an issue without the labels "help wanted", "good first issue". Since you're a new contributor, you can only claim and submit pull requests for issues with the help wanted or good first issue labels.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

zulipbot avatar Feb 05 '21 17:02 zulipbot

@zulipbot add "help wanted"

ganpa3 avatar Feb 05 '21 17:02 ganpa3

@zulipbot claim

ganpa3 avatar Feb 05 '21 17:02 ganpa3

Welcome to Zulip, @ganpa3! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-desktop/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

zulipbot avatar Feb 05 '21 17:02 zulipbot

@rht Would you please review the PR https://github.com/zulip/zulip-desktop/pull/1074 related to this issue?

ganpa3 avatar Feb 10 '21 17:02 ganpa3

@yaminijha1 You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

zulipbot avatar Mar 07 '21 19:03 zulipbot

@zulipbot ok

ganpa3 avatar Mar 08 '21 02:03 ganpa3

can i contribute

SidharajYadav avatar Jan 17 '22 05:01 SidharajYadav

@zulipbot claim

yaminijha1 avatar Jan 07 '24 09:01 yaminijha1

Welcome to Zulip, @yaminijha1! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-desktop/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

zulipbot avatar Jan 07 '24 09:01 zulipbot

@zulipbot claim

yaminijha1 avatar Jan 15 '24 04:01 yaminijha1

@zulipbot @timabbott I have created PR #1350 to fix this issue, Can you please review this PR?

yaminijha1 avatar Jan 15 '24 04:01 yaminijha1

@yaminijha1 You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

zulipbot avatar Jan 25 '24 09:01 zulipbot

@priyank-p, can you please describe why this issue remains open? Initially, we had Appveyor for Windows, and then I defined a GitHub action for Windows in this PR #1350

If possible can you please review it?

yaminijha1 avatar Mar 03 '24 18:03 yaminijha1