zulip-desktop icon indicating copy to clipboard operation
zulip-desktop copied to clipboard

Ctrl + (+) and Ctrl + (-) are missing form Keyboard shortcuts menu

Open JulianGro opened this issue 4 years ago • 7 comments

Describe the bug Ctrl + + and Ctrl + - are missing form Keyboard shortcuts menu in the bottom right.

Expected behavior It should tell you about these important shortcuts.

Desktop (please complete the following information):

  • Operating System: Linux Mint 19.3 (Ubuntu 18.04.3)
  • Zulip Desktop Version: 5.4.0

Additional context Zulip is pretty small by standard. A lot of users will want to increase its size by pressing Ctrl + +

JulianGro avatar Sep 22 '20 17:09 JulianGro

Does this shortcut work for you -

image

akashnimare avatar Sep 23 '20 07:09 akashnimare

That is something I have missed. I cannot press Ctrl + =, as = is not a dedicated button on a QWERTZ keyboard.

JulianGro avatar Sep 23 '20 08:09 JulianGro

Contrary to what the menu says, zooming in for me is Ctrl + + and not Ctrl + =. Windows 6.1.7601, Zulip Desktop v5.4.3, Italian keyboard layout.

When using the EN-US keyboard layout, Ctrl + = zooms in, but does so by two steps instead of one; this is both visually noticeable as it happens in two steps, and can easily be checked: pressing Ctrl + - twice is needed to go back to what it was.

simolev avatar Oct 19 '20 07:10 simolev

@akashnimare can you assign this issue to me.

skshamagarwal avatar Jan 12 '21 05:01 skshamagarwal

#1063 Issue fixed - ready for review

skshamagarwal avatar Jan 12 '21 14:01 skshamagarwal

The fix for this issue likely does not involve adding all desktop app shortcuts these to the in-webapp keyboard shortcuts menu; instead, we should probably just add a simple hint in the webapp codebase conditional on electron_bridge directing users how to find the desktop app keyboard shortcuts as well.

timabbott avatar Mar 25 '21 00:03 timabbott

I agree a note on the ? keyboard shortcuts menu to the effect of "Look at the menu bar for more system-related shortcuts (zoom,dev tools, etc.)"

nuke-web3 avatar Mar 15 '24 21:03 nuke-web3