zulip-desktop
zulip-desktop copied to clipboard
zulip
add organization: url: attempt to autocomplete with zulipchat.com
Problem Description
Expected: overnode.zulipchat.org
Proposed Solution If the entered string does:
- match the organization url conditions (Subdomain can only have lowercase letters, numbers, and dashes.)
- (including) doesn't start with a protocol (https://overnode should still work)
- (including) doesn't contain any dots, aka any TLDs.
If the URL will be autocompleted, Show that within the text box (with grey text?).
Describe alternatives you've considered Give the user a first time impression of ERROR?
I might attempt to close this myself within tommorow - 3 months
Thanks for the feedback! Yeah, I'd like to see this changed in the desktop app as well. We should be smart about the UX details around this though -- we want to make it very clear what URL users will be connecting to if they submit the form. One possible option would be to have two text boxes, with the top one being https://_____.zulipchat.com.
(I don't think the Android app's exact implementation on this is particularly good)
It make sense to autocomplete the url in the mobile app but in the desktop app, we should try to keep it as simple as possible. Don't need to add too much autocompletion and all. I think having two views (Self-hosted, zulipchat.com) would make sense here.
UX? One box, if the current text input matches the conditions, show <input placeholder=".zulipchat.com">-like thing, grey text at the right of the text input.
Yeah, I think that's better. We can assume https unless the URL starts with http:// (support for which is mainly for testing with the development environment).
I think some selfhosted folks could have something like http://zulip defined for their internal network. In those cases it would break for them. The solution for that would be to have two input boxes. Perrsonally I feel it maybe confusing/bad UX.
As I mentioned before: hosted → https://hosted.zulipchat.com http://hosted → http://hosted https://hosted → https://hosted
With http, you would need to type http:// anyways, as we can default to https://. I don't see the problem here.
Adding the gray .zulipchat.com appended when no protocol is found, and the instance name is compatible with the naming rules makes it even more clear?
How is this exactly handled in the mobile app? Did we miss something?
Yeah, @jtagcat's comment reflects what I had in mind; I believe that's the algorithm the mobile app uses at a high level.
@gnprice FYI.
Are you still working on this? @aryanshridhar or should I take it forward.
Hey @Signior-X , I have already added the necessary changes within #1043 . Would be great if you could address something which I accidentally left out .
Respect Sir, I'm Siddharaj Yadav a computer engineering undergraduate, Pursuing TE at D Y Patil College under (Pune University). I am new to open source contribution but I am well aware of Python,Django,HTML and Git& GitHub. I would to contribute to your organization but could you please tell me how to get started? Gsoc Hoping to hear from you soon Regards Siddharaj Yadav
mail- [email protected]
Hey i am new to open source development and want to work on this can you please assign me this.
@SidharajYadav Start at our documentation about contributing to Zulip. Please don’t comment on GitHub issues with unrelated questions.
Any chance I could take this a little further? I built off of #1043 and added a UX similar to the one's found in the mobile apps
Here is what it could look like:
let me know and I'll make a new PR for this issue
Welcome to Zulip, @manila! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-desktop/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!
Here's some tips to get you off to a good start:
- Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
- Unwatch this repository, so that you don't get 100 emails a day.
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.
See you on the other side (that is, the pull request side)!
@manila We noticed that you have not made any updates to this issue or linked PRs for 10 days. Please comment here if you are still actively working on it. Otherwise, we'd appreciate a quick @zulipbot abandon comment so that someone else can claim this issue and continue from where you left off.
If we don't hear back, you will be automatically unassigned in 4 days. Thanks!
It looks like this could still be up for discussion so I'll remove myself from this issue. There is likely a better solution for this, and if this continues to remain open I may take another shot at it :)
