zulip-android-legacy icon indicating copy to clipboard operation
zulip-android-legacy copied to clipboard

Adds an arrow in front of a expandable stream to expand and contract …

Open abhaymaniyar opened this issue 7 years ago • 8 comments

…that stream.

Summary of changes When a user clicked on a stream in the stream pane, it narrows down the stream. Now if a user clicks on the stream it expands the stream and shows the topics that the stream contains. Screenshots or a brief video showing the change in action:

ezgif com-optimize 3

Please make sure these boxes are checked before submitting your pull request - thanks! Guide

  • [x] Code is formatted.

  • [x] Run the lint tests with ./gradlew lintDebug and make sure BUILD is SUCCESSFUL

  • [x] If new feature is implemeted then it is compatible with Night theme too.

  • [x] Commit messages are well-written.

abhaymaniyar avatar Mar 15 '17 15:03 abhaymaniyar

Automated message from Dropbox CLA bot

@abhaymaniyar, it looks like you've already signed the Dropbox CLA. Thanks!

smarx avatar Mar 15 '17 15:03 smarx

@Sam1301 Please review and help me to resolve merge conflicts.

abhaymaniyar avatar Mar 15 '17 15:03 abhaymaniyar

Thank you @saketkumar95 :). Can you please help me with the conflicts here?

abhaymaniyar avatar Mar 16 '17 10:03 abhaymaniyar

Thanks for reviewing @kunall17! Is there any variable in the code base which stores the number of topics in a stream?

abhaymaniyar avatar Mar 22 '17 15:03 abhaymaniyar

@kunall17 I am trying to implement what you said but there is a problem. I get the number of subjects in a stream only when I click on the stream. How can I get the number of subjects in a stream on launch of MainActivity?

abhaymaniyar avatar Mar 25 '17 07:03 abhaymaniyar

Yeah, true it only get's calculated when the expansion of the expandableListItem is done, so should we have arrow in all? Maybe show a message, no topics found?

kunall17 avatar Mar 29 '17 11:03 kunall17

Great! I can do that.

abhaymaniyar avatar Mar 31 '17 06:03 abhaymaniyar

@abhaymaniyar, your pull request has developed a merge conflict! Please review the most recent commit (f791888) for conflicting changes and resolve your pull request's merge conflicts.

zulipbot avatar May 04 '17 18:05 zulipbot