zulip-android-legacy icon indicating copy to clipboard operation
zulip-android-legacy copied to clipboard

Fixes #386 : Compose box doesn't auto-open when narrowing

Open saketkumar opened this issue 8 years ago • 7 comments

Summary of changes

This PR fixes https://github.com/zulip/zulip-android/issues/386 Now compose box doesn't auto-open when narrowing.

Screenshots or a brief video showing the change in action: chatbox

  • [x] Code is formatted.

  • [x] Run the lint tests with ./gradlew lintDebug and make sure BUILD is SUCCESSFUL

  • [x] Commit messages are well-written.

saketkumar avatar Feb 10 '17 12:02 saketkumar

Automated message from Dropbox CLA bot

@saketkumar95, it looks like you've already signed the Dropbox CLA. Thanks!

smarx avatar Feb 10 '17 12:02 smarx

Yes, the issue was with message headers ("recipient bars" is what we call them usually).

timabbott avatar Feb 27 '17 02:02 timabbott

@timabbott @Sam1301 Yeah, i got that wrong. But i think this should also be there. Whenever someone clicks on the stream, the compose box automatically opens up. Instead it should not. Same as on web. Thoughts?

saketkumar avatar Feb 27 '17 02:02 saketkumar

Agreed, maybe just add a second commit fixing the other issue?

timabbott avatar Feb 27 '17 04:02 timabbott

@timabbott Yeah, sure. :)

saketkumar avatar Feb 27 '17 04:02 saketkumar

@saketkumar95 this looks nice, can you please address the comment here?

Sam1301 avatar Mar 27 '17 04:03 Sam1301

@saketkumar95, your pull request has developed a merge conflict! Please review the most recent commit (f791888) for conflicting changes and resolve your pull request's merge conflicts.

zulipbot avatar May 04 '17 18:05 zulipbot