zulip-android-legacy icon indicating copy to clipboard operation
zulip-android-legacy copied to clipboard

Published 20 hours ago • verified publisher icon zulip

Add highlight and show how to use some features

Open minervapanda opened this issue 9 years ago • 9 comments

I could not upload the whole video. This pr addresses : [x] Swipe to remove the chatbox [x] Switching streams from the menu [x] Private chat drawer [x] Long press on message for more options

ezgif com-video-to-gif

Solves : Highlight and show how to use some features of the app which are not easily visible - #161

minervapanda avatar Oct 12 '16 06:10 minervapanda

Automated message from Dropbox CLA bot

@minervapanda, it looks like you've already signed the Dropbox CLA. Thanks!

smarx avatar Oct 12 '16 06:10 smarx

Thankyou for working on this!

  • Rather than creating activities which shows static images, you could easily make multiple showcase views like it is done here https://github.com/amlcurran/ShowcaseView/blob/master/sample/src/main/java/com/github/amlcurran/showcaseview/sample/MemoryManagementTesting.java (Got this one from this issue https://github.com/amlcurran/ShowcaseView/issues/325) in the ZulipActivity.java file
    And while switching showcases you could programitically open/close the drawers etc
  • Add a help option in the overFlow menu which would show these highlights
  • Tweak with background and foreground text Color as the current scheme makes it hard to read the text. Maybe decrease the opacity of the background if possible!

kunall17 avatar Oct 12 '16 17:10 kunall17

And also remove the commit a475f45 from this PR, as this is not related to this feature!

kunall17 avatar Oct 12 '16 18:10 kunall17

Hi @kunall17 , I added the help option to the menu and similar way of implementation is in ChatBoxFeature java file. Give a look. We need to show different layouts for different demonstration for other features. Also removed the unwanted commits

minervapanda avatar Oct 14 '16 08:10 minervapanda

@minervapanda could you add a little more detail to the commit message (customs explained https://zulip.readthedocs.io/en/latest/version-control.html#commit-messages ) to list the features that get demonstrated in this new showcase?

brainwane avatar Oct 14 '16 22:10 brainwane

Hey @minervapanda, have you had a chance to look over the suggestions from Sumana and Kunal yet?

niftynei avatar Oct 18 '16 21:10 niftynei

@minervapanda Due to recent merges in master, merge conflicts have been created. Please try to resolve them.

yadav-rahul avatar Jan 14 '17 17:01 yadav-rahul

@yadav-rahul This PR is no longer valid. @timabbott @kunall17 I think this should be closed.

saketkumar avatar Jan 14 '17 18:01 saketkumar

@minervapanda, your pull request has developed a merge conflict! Please review the most recent commit (f791888) for conflicting changes and resolve your pull request's merge conflicts.

zulipbot avatar May 04 '17 18:05 zulipbot