python-zulip-api icon indicating copy to clipboard operation
python-zulip-api copied to clipboard

Published 20 hours ago • verified publisher icon zulip

zulip: Add tests for API functions.

Open LoopThrough-i-j opened this issue 3 years ago • 4 comments

LoopThrough-i-j avatar Apr 29 '21 11:04 LoopThrough-i-j

I was thinking of simulating an event queue for testing call_on_each_event but restricted myself from doing that thinking of the previous comments and from the prospects of setting up an integration test suite.

LoopThrough-i-j avatar May 12 '21 22:05 LoopThrough-i-j

@timabbott a review on this if possible would be great.

LoopThrough-i-j avatar May 12 '21 22:05 LoopThrough-i-j

@timabbott thanks for the review I will update the PR shortly, with required comments and explanations as best as I can.

LoopThrough-i-j avatar May 25 '21 13:05 LoopThrough-i-j

Heads up @LoopThrough-i-j, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

zulipbot avatar May 31 '23 00:05 zulipbot