python-zulip-api icon indicating copy to clipboard operation
python-zulip-api copied to clipboard

Adding fetch_upload method to client

Open Ponni-M opened this issue 3 years ago • 3 comments

https://github.com/zulip/python-zulip-api/issues/628

Ponni-M avatar Apr 18 '21 13:04 Ponni-M

@Ponni-M can you restructure the commits to first refactor the /api/ prefix stuff, with a commit message explaining why that's correct, and then one adding the new endpoint?

Check out the Zulip commit message guidelines for more details: https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages

timabbott avatar May 24 '21 21:05 timabbott

@Ponni-M thanks for working on this, added a comment. Everything else LGTM.

LoopThrough-i-j avatar May 25 '21 13:05 LoopThrough-i-j

Heads up @Ponni-M, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

zulipbot avatar Aug 24 '21 19:08 zulipbot