python-zulip-api icon indicating copy to clipboard operation
python-zulip-api copied to clipboard

bot tests: Created tests for Merels

Open NealMatta opened this issue 5 years ago • 3 comments

This PR improves test coverage from 0% to 98%.

This PR directly tackles issue #433

NealMatta avatar Apr 22 '19 06:04 NealMatta

Just in case anyone want's to continue to work on this error, the tests which I wrote work locally and provide a line coverage of 98%. Travis CI is failing on merels/libraries/game_data.py and merels/libraries/mechanics.py because these files have circular imports with one another. I tried doing a bit of research and implementing changes to no avail.

NealMatta avatar Apr 22 '19 23:04 NealMatta

@NealMatta: I've run into this before, here's a quick suggested fix (which should work):

I would take a look at the function or block that is causing the error and move the offending import statement there. Usually, circular import errors can be fixed that way, but it is only a quick fix. A better fix would be to remove the circular dependency altogether! :) Thanks!

eeshangarg avatar Apr 23 '19 22:04 eeshangarg

Heads up @NealMatta, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/master branch and resolve your pull request's merge conflicts accordingly.

zulipbot avatar Apr 19 '20 03:04 zulipbot