python-zulip-api icon indicating copy to clipboard operation
python-zulip-api copied to clipboard

Zulip client should detect the presence of a zuliprc in $PWD.

Open rht opened this issue 6 years ago • 8 comments

Reading from ~/.zuliprc forces the number of account to be 1. The other alternative, i.e. having to type the API key in a command line is not secure (this leaves trails in the history). Additionally, having a local and global config has been practiced by npm for a while.

If this is to be implemented, another consideration is whether to make the zuliprc visible or not.

note: zulip-terminal has already implemented this local config detection. See also bridge_with_matrix.

rht avatar Jan 21 '19 16:01 rht

We already support just having users pass the path to a .zuliprc file, right?

timabbott avatar Feb 03 '19 06:02 timabbott

Huh, yeah, I could have used that instead of passing the API key, but again, it is more convenient if the client anticipates that .zuliprc is in the current directory. So the remaining argument is for convenience and that npm does it.

rht avatar Feb 03 '19 19:02 rht

@zulipbot claim

orientor avatar Feb 21 '20 21:02 orientor

Welcome to Zulip, @orientor! We just sent you an invite to collaborate on this repository at https://github.com/zulip/python-zulip-api/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

zulipbot avatar Feb 21 '20 21:02 zulipbot

PR added. Please review. Also how should we change the docs in this case?

orientor avatar Feb 22 '20 00:02 orientor

Hello @orientor, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

zulipbot avatar Mar 11 '20 10:03 zulipbot

@zulipbot claim

gvarun1 avatar Jun 16 '21 04:06 gvarun1

Hello @gvarun1, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

zulipbot avatar Jun 16 '21 04:06 zulipbot