python-zulip-api
python-zulip-api copied to clipboard
Make giphy logo optional (when legal)
For legal reasons our giphy bot shows a "Powered by Giphy" logo.
For users that sign up for Giphy accounts (presumably paid) that don't require the logo, we should have an option in the bot that turns off the powered-by logo.
The first step here is to track down the policy from Giphy and understand it to the best of your ability.
Then subsequent steps will be something like this:
- add config options that the giphy bot can read
- possibly check in smaller versions of the logo
- add documentation to the bot (particularly if people want to use giphy images for the avatar)
- possibly open server-side issues to the extent that we want powered-by-giphy in avatars (like it could be a bot setting, I don't know)
As per the terms from Giphy, the "Powered by GIPHY" logo is required.
From the docs:
As per our section 5 A of our terms of service, we require all apps that use the GIPHY API to conspicuously display "Powered By GIPHY" attribution marks where the API is utilized.
This applies even if one obtains a "Production API key"( A Production API key can make more number of requests than the normal API key. )
Infact, one of the conditions to obtain a "Production API key" is to display the attribution marks wherever the API is used.
GIPHY Developer docs: https://developers.giphy.com/docs/ GIPHY FAQ: https://developers.giphy.com/faq/
@zulipbot claim (zulipbot is not allowing me claim but I am working on this issue.)
Hello @Ar9av!
Thanks for your interest in Zulip! You have attempted to claim an issue without the labels "help wanted", "good first issue". Since you're a new contributor, you can only claim and submit pull requests for issues with the help wanted or good first issue labels.
If this is your first time here, we recommend reading our guide for new contributors before getting started.