python-zulip-api icon indicating copy to clipboard operation
python-zulip-api copied to clipboard

Rework and enable tests for Merels.

Open amanagr opened this issue 6 years ago • 38 comments

Merels was ported to game_handler recently, but it's tests were not revised. They need to be reworked. Tests for connect_four bot can serve as good examples for how to modify the tests for Merels.

merels.py was totally changed so write new set of tests for it. Files in libraries were not much changed so they need to be tweaked to accomodate for the changes.

Enable testing for merels by adding __init__.py file to the directory.

amanagr avatar Jun 10 '18 04:06 amanagr

See the following for a good first commit to work from: https://github.com/zulip/python-zulip-api/pull/403/commits/bd945c3d5b7558864ecd2ab681a404cbaa63cb07

neiljp avatar Jun 10 '18 05:06 neiljp

@zulipbot claim

JordanTroutman avatar Jun 23 '18 01:06 JordanTroutman

Welcome to Zulip, @JordanTroutman! We just sent you an invite to collaborate on this repository at https://github.com/zulip/python-zulip-api/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

zulipbot avatar Jun 23 '18 01:06 zulipbot

@zulipbot claim

JordanTroutman avatar Jun 23 '18 01:06 JordanTroutman

Hello @dsolisherrera, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

zulipbot avatar Jul 03 '18 04:07 zulipbot

Issue waiting for pull rquest

JordanTroutman avatar Jul 03 '18 22:07 JordanTroutman

Hello @JordanTroutman, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

zulipbot avatar Jul 13 '18 22:07 zulipbot

Hi, this seems like a good issue to get involved. I would like to take a look.

@zulipbot claim

dsolisherrera avatar Aug 28 '18 20:08 dsolisherrera

Welcome to Zulip, @dsolisherrera! We just sent you an invite to collaborate on this repository at https://github.com/zulip/python-zulip-api/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

zulipbot avatar Aug 28 '18 20:08 zulipbot

@zulipbot claim

dsolisherrera avatar Aug 28 '18 20:08 dsolisherrera

Hi @amanagr, is there a place where I can find documentation on this bot? I was able to make the tests run based on the comment from neiljp. But I would like to see what it does and understand it before starting to modify the tests.

dsolisherrera avatar Aug 28 '18 21:08 dsolisherrera

There is no documentation for the Merels bot. You can look at comments and git history of the code for some. You should first try to understand how tests for other bots are written, then it will be a lot easier to grab this one.

amanagr avatar Aug 29 '18 04:08 amanagr

@zulipbot claim

bymayanksingh avatar Jan 14 '19 19:01 bymayanksingh

Welcome to Zulip, @code-monk08! We just sent you an invite to collaborate on this repository at https://github.com/zulip/python-zulip-api/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

zulipbot avatar Jan 14 '19 19:01 zulipbot

Hello @sjha2048, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

zulipbot avatar Jan 24 '19 20:01 zulipbot

@zulipbot abandon

bymayanksingh avatar Jan 24 '19 21:01 bymayanksingh

@zulipbot claim

sjha2048 avatar Feb 03 '19 06:02 sjha2048

Welcome to Zulip, @sjha2048! We just sent you an invite to collaborate on this repository at https://github.com/zulip/python-zulip-api/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

zulipbot avatar Feb 03 '19 06:02 zulipbot

@zulipbot claim

bendemers avatar Mar 20 '19 16:03 bendemers

Welcome to Zulip, @bendemers! We just sent you an invite to collaborate on this repository at https://github.com/zulip/python-zulip-api/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

zulipbot avatar Mar 20 '19 16:03 zulipbot

Hello @bendemers, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

zulipbot avatar Mar 30 '19 20:03 zulipbot

@zulipbot claim

NealMatta avatar Apr 07 '19 23:04 NealMatta

Welcome to Zulip, @NealMatta! We just sent you an invite to collaborate on this repository at https://github.com/zulip/python-zulip-api/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

zulipbot avatar Apr 07 '19 23:04 zulipbot

Hello @NealMatta, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

zulipbot avatar Apr 18 '19 02:04 zulipbot

@zulipbot Currently working through some bugs

NealMatta avatar Apr 21 '19 03:04 NealMatta

@zulipbot claim

Kodhandarama avatar Sep 03 '19 17:09 Kodhandarama

Welcome to Zulip, @Kodhandarama! We just sent you an invite to collaborate on this repository at https://github.com/zulip/python-zulip-api/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

zulipbot avatar Sep 03 '19 17:09 zulipbot

Hello @Kodhandarama, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

zulipbot avatar Sep 13 '19 19:09 zulipbot

@zulipbot claim

TarunGuptaJ avatar Oct 03 '19 11:10 TarunGuptaJ

Welcome to Zulip, @TarunGuptaJ! We just sent you an invite to collaborate on this repository at https://github.com/zulip/python-zulip-api/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

zulipbot avatar Oct 03 '19 11:10 zulipbot