python-zulip-api icon indicating copy to clipboard operation
python-zulip-api copied to clipboard

Published 20 hours ago • verified publisher icon zulip

Improve tests for game_handler.

Open fremiller opened this issue 7 years ago • 5 comments

game_handler is used by game bots to make turn based games.

There are connect_four tests, but they are all written from scratch, and are quite messy. There are few tictactoe tests.

There should be a test case for game_handler games, which would make it simpler to make tests for games, and all the games should have 100% coverage.

fremiller avatar Jan 19 '18 16:01 fremiller

@zulipbot claim

fremiller avatar Jan 19 '18 16:01 fremiller

Hello @fredfishgames, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

zulipbot avatar Jan 29 '18 17:01 zulipbot

@fredfishgames are you still working on this? Can I take this? I think this is an extension to #122 which I am doing currently.

amanagr avatar Feb 03 '18 15:02 amanagr

@amanagr I don't have much time to work on it at the moment, so feel free to take it. Let me know if you have any questions about game_handler

fremiller avatar Feb 03 '18 21:02 fremiller

Hi! Do you think it is still an issue? I can take on this.

zihanqiuu avatar Nov 10 '22 23:11 zihanqiuu