fakeldap icon indicating copy to clipboard operation
fakeldap copied to clipboard

avoid dependency on ldap by optionally faking the exceptions

Open graingert opened this issue 5 years ago • 5 comments

graingert avatar May 31 '19 13:05 graingert

@eeshangarg we currently use python-ldap~=2.4 and although we are looking to upgrade we're not yet ready to do so. When installing this testing package we are forced to upgrade to python-ldap~=3.0 which conflicts

graingert avatar May 31 '19 13:05 graingert

this also allows people to test without having python-ldap installed at all:

import sys
import fakeldap

sys.modules['ldap'] = fakeldap.ldap

graingert avatar May 31 '19 13:05 graingert

@graingert: Thanks for working on this! Looks good to me! :)

@timabbott: Could you please take a quick look as well? Thanks!

eeshangarg avatar May 31 '19 21:05 eeshangarg

Makes sense to me; posted a quick comment on documentation.

timabbott avatar May 31 '19 22:05 timabbott

Possibly we should also add a brief section at the bottom of the README mentioning this behavior, maybe with a title like "Usage without ldap installed".

timabbott avatar May 31 '19 22:05 timabbott