docker-zulip icon indicating copy to clipboard operation
docker-zulip copied to clipboard

Provide better error messages for invalid environment variables

Open jinithin opened this issue 5 years ago • 2 comments

It seems like the variable PUSH_NOTIFICATION_REDACT_CONTENT: 'True' does not have any effect on the server when specified in the docker-compose.yml file.

Can this be included, or is there another preferred way to do it?
Would rather not mount the settings-file to the container.

jinithin avatar Jun 18 '19 12:06 jinithin

It should be:

environment:
  SETTING_PUSH_NOTIFICATION_REDACT_CONTENT: "True"

(that is, you're missing the SETTING_ prefix)

sirpengi avatar Jun 19 '19 18:06 sirpengi

Yep, that's correct -- we document you need to use the SETTING_ prefix for anything that you want in settings.py.

We should probably figure out a way to do some sort of warning for this type of situation, if it's possible.

timabbott avatar Jun 19 '19 22:06 timabbott