docker-zulip
docker-zulip copied to clipboard
zulip
Some improvements for Dockerfile
- Bump to Ubuntu Bionic
- Make use of
DEBIAN_FRONTEND=noninteractive - Install, and init locale not inside python script from travis
- Try to use poor's man solution to run this without log files, didn't work, see #176
- Make look more readable
- Don't move tar-gz into layer, use unpacked from build stage
@Savemech thanks for the contributions! I think some of the changes (e.g. removing comments) are probably counterproductive for users who are not experts in using Docker. Some of the other changes (e.g. readability improvements) seem nice and I'd be happy to integrate if they were in separate commits. Would you be up for reorganizing this branch to start with the most easily mergable changes in separate commits (e.g. readability improvements) and do one commit per distinct fix?
Check out our GitHub guide and commit guidelines for more details.
Add some comments, and maybe I would check some problems that highlighted, and find some way to improve size of resulting image(that bothers me a lot), because were building Zulip for every commit in master automatically and for now its average of ~45 mins
Sorry for the delay -- holidays hit. @andersk can you take over reviewing this?
@Savemech If you want to help things along, follow the guidelines that Tim linked (GitHub guide, commit guidelines). For example, there could be one commit that just does the bump to bionic (with no other changes, except any that might be required for the bionic bump), one commit that just does the tar.gz changes, and so on. This is the organization we’ll need before we can merge anything, and it’s helpful during review.
DEBIAN_FRONTEND=noninteractive could be set using ARG so it doesn’t need to be duplicated everywhere.
What was going wrong without the timezone configuration?
Closing, since many of the changes are stale (we've since done them via other PRs) and others are not well separated.
Thanks for your work on this @Savemech!