notepad4 icon indicating copy to clipboard operation
notepad4 copied to clipboard

Can't change the scroll bar color

Open J-PRS opened this issue 1 year ago • 7 comments

It would complete the dark theme look.

2024-06-29_15-22-Notepad2_y5c8NBR3Uz

J-PRS avatar Jun 29 '24 13:06 J-PRS

The same goes for the toolbar background but this would probably require redesigning some icons to improve readability with this theme. If needed as done in the past for the adaptation of the icons I am available.

Matteo-Nigro avatar Jun 29 '24 14:06 Matteo-Nigro

Yeah, though I've never used the icons, and the menu only for changing settings, so just the bar would be enough for me. Minimum viable fully dark themed product.

J-PRS avatar Jun 29 '24 15:06 J-PRS

Hi, 我已经尝试整合三方的代码,修改了一个 dark theme 的版本(DarkMode 分支),主要就是针对上面所提到的 toolbar 和 menubar 以及 scroll bar 在 darkmode 的问题,运行效果如下图:

image

Jackarain avatar Aug 21 '24 09:08 Jackarain

I confirm that if this is implemented in Notepad4 the icons will have to be revised.

Matteo-Nigro avatar Aug 21 '24 10:08 Matteo-Nigro

Hi, 我已经尝试整合三方的代码,修改了一个 dark theme 的版本

Your code uses std::mutex, the exe is not granted to be runnable on earlier system, see https://github.com/microsoft/STL/issues/946. https://github.com/zufuliu/notepad4/blob/01d55f321a6394ba2d4f3702da9af8d490de7ebc/scintilla/src/ParallelSupport.h#L39-L43

zufuliu avatar Aug 21 '24 11:08 zufuliu

感谢 @zufuliu 指出,让我了解到 msvcstd::mutex 已经放弃支持在更早的 windows 版本上运行。

不过需要说明的是,那并不是我写的代码,我只是简单的整合了人家的代码(最初作者:https://github.com/ysc3839/win32-darkmode/)到 notepad4 中以达到基本界面能拥有的 Dark 效果。

Jackarain avatar Aug 21 '24 12:08 Jackarain

image

暗色主题,不能完全覆盖UI太难受了,何时能够用上呀😥

antnesswcm avatar Oct 10 '24 06:10 antnesswcm