Zufu Liu

It's not a bug, actually changed in Scintilla 3.6.7 https://www.scintilla.org/ScintillaHistory.html > SC_CHARSET_DEFAULT now means code page 1252 on Windows unless a code page is set. This prevents unexpected behaviour and...

But most app had changed that line, e.g. I use `case SC_CHARSET_DEFAULT: return documentCodePage;`. https://github.com/zufuliu/notepad2/blob/master/scintilla/win32/ScintillaWin.cxx#L1460

@cshnik, I don't use SC_CHARSET_ANSI, but patched Scintilla for SC_CHARSET_DEFAULT to `case SC_CHARSET_DEFAULT: return documentCodePage;`, see https://sourceforge.net/p/scintilla/bugs/2093/#3ee4/1677 and https://github.com/zufuliu/notepad2/blob/master/scintilla/win32/ScintillaWin.cxx#L1471

The bug is because `StrTrimA(pmsz, "\r\n");` , see https://github.com/zufuliu/notepad2/issues/168 and https://github.com/zufuliu/notepad2/commit/7192b4092dcc1dd874e34ef3fdb3bfbad81356f8

Possible, it worth to document that, `n2e_StrTrimA` only works when `pszTrimChars` doesn't contains DBCS trail bytes (see Scintilla's `Document::IsDBCSTrailByteInvalid()` method), it absolutely works for C0 control characters (`\n\r\t\v\f` space, etc.).

complex examples from (links taken from https://clang.llvm.org/cxx_status.html) http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/p0306r4.html http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p1042r1.html ```cpp #define SDEF(sname, S, ...) S sname __VA_OPT__(= { __VA_ARGS__ }) SDEF(foo, 1); SDEF(bar, 1, 2, 3); extern int printf(const char...

It works in Legacy GDI mode (Settings -> Rendering Technology), but not in Direct2D mode. It fails on following code, where `hr` is `DWRITE_E_NOFONT` (`_HRESULT_TYPEDEF_(0x88985002L)`): https://github.com/zufuliu/notepad2/blob/0688888a3b5fa1c14d08f45ff542761f3895b9ee/scintilla/win32/PlatWin.cxx#L314-L316

> It works in Legacy GDI mode (Settings -> Rendering Technology), but not in Direct2D mode. Oh, the menu is actually under Settings -> Advanced Settings -> Rendering Technology. On...

There is maybe related bug report at https://sourceforge.net/p/scintilla/bugs/2262/.

Fixdsys on my Win 10, it works in GDI (in auto-completion box), but not in editor windows (text rendered with DirectWrite).