pytorch_connectomics icon indicating copy to clipboard operation
pytorch_connectomics copied to clipboard

Published 20 hours ago • verified publisher icon zudi-lin

Bug: AttributeError in VolumeDataset when not providing a label list

Open Lauenburg opened this issue 3 years ago • 2 comments

Steps to reproduce

Use VolumeDataset without specifying a list of labels.

In line 48, the label list is initialized with None.

In line 88 with set self.label_vol_ratio = self.sample_label_size / self.sample_volume_size if self.label is not None.

However, in line 232 self.label_vol_ratio is referenced even if the label list was not initialized and consequently self.label_vol_ratio was never defined.

Current behavior (bug)

Raises AttributeError

Expected behavior (correct)

Should be able to process a data volume without providing a list of labels since label has a default value of None.

/label ~Bug

Lauenburg avatar Jan 20 '22 16:01 Lauenburg

Fixed with PR #101

zudi-lin avatar Jan 30 '22 18:01 zudi-lin

@Lauenburg could you add your test function for different input cases you tried, e.g., mode='train', volume=data, lable=None, valid_mask=data to tests/? Please create a new file called test_data_loading.py

zudi-lin avatar Feb 01 '22 19:02 zudi-lin