node-jmx
node-jmx copied to clipboard
Modified to support Weblogic JMX
Thank you for providing such a great module.
While I was trying to use your module for Weblogic Server MBeans with JMX using t3 protocol, I fount that it must use different protocolProvider, and some of libraries from Oracle.
I'm not sure if this change is against your philosophy, but I decided to do a pull request for the reference to someone, who might have same problem as me.
Again, thanks a lot for providing a great module.
Hi @juhgiyo,
Wow! thanks for your PR, I'm really interested in merging it :smiley:
But I think it would be good to improve some issues before:
- Fix coverage: tests are missing (See the coveralls report).
- Duplicated code: I think the waiting logic should be refactored to its own function.
MBeanServerConnection#connectfunction is getting too big. - I'm not sure about this, do you think including wlclient.jar (472KB) in the module is a good idea? Maybe we can document that is required to download it manually.
It's OK if you do not have time for this now. I'll leave this PR open whatever time it takes.