zstadler

> Thanks! Maybe one improvement for `valley` should be `LineLabel` function (example in `water_name` layer). Some of the valleys could be very short even for zoom 13 e.g. https://www.openstreetmap.org/way/451566241. >...

@TomPohys, On second thought, I prefer not to expand this PR. The intention here is for a minimal addition to the layer where `natural=valley` would follow the existing handling of...

The style spec contains two means to access the geometry type of an element, each has a different set of possible velues: 1. [`["geometry-type"]`](https://maplibre.org/maplibre-style-spec/expressions/#geometry-type) Gets the feature's geometry type: `Point`,...

The problem, as far as I understand, is unrelated to GeoJSON. Here is an example where the vector tiles were created from OSM data by OpenMapTiles. Here is an inner...

@sbachinin, @HarelM, The MVT Spec [also says](https://github.com/mapbox/vector-tile-spec/blob/master/2.1/README.md#4344-polygon-geometry-type) (my emphasis on **MUST**): > If the command sequence for a POLYGON geometry type includes only a single exterior ring then the geometry...

Here is a proposal to sort this out: - `["geometry-type"]` will always give the detailed geometry, including the classification of MVT features as "Multi"* geometries. - `"$type"` will always give...

EDIT: Changed the code below to make the map view more informative I think we have been discussing this issue under an assumption that `["geometry-type"]` differentiates between `Polygon` and `MultiPolygon`....

I've modified the "Maptiler Basic" style as described above. When opening [this style](https://github.com/maplibre/maplibre-gl-js/files/14125490/basic.json) in Maplibre Maputnik, the Inspect view says the `$type` of the area is `MultyPolygon`:  On the...

### Summary of the approach taken in PR https://github.com/maplibre/maplibre-style-spec/pull/519 The style spec for [`["geometry-type"]`](https://maplibre.org/maplibre-style-spec/expressions/#geometry-type) says it _"Gets the feature's geometry type: `Point`, `MultiPoint`, `LineString`, `MultiLineString`, `Polygon`, `MultiPolygon`."_ However the implementation...

It looks like the current Maplibre Native implementation above may also be different than the [current maplibre-style-spec implementation](https://github.com/maplibre/maplibre-style-spec/blob/4a693c05fe5474e3a42e23612d908e6f519082c6/src/expression/evaluation_context.ts#L32-L34). ``` geometryType() { return this.feature ? typeof this.feature.type === 'number' ? geometryTypes[this.feature.type]...