MagicKeys icon indicating copy to clipboard operation
MagicKeys copied to clipboard

Published 20 hours ago • verified publisher icon zsszatmari

Code updates

Open smarek opened this issue 9 years ago • 1 comments

Fixed universal developer ID, GC converted to ARC, unchecked signed-unsigned casts explicitly stated, fixed initial position of preferences XIB

Overall just some small changes and warnings fixed, when opening project in XCode (my env XCode 6.3.2, Yosemite 10.10.3)

Summary

  • XIB is default positioned in center of screen, not on absolute coordinates
  • Replaced old GC with ARC
  • Explicitly casted returns with unsigned casts (fixed warnings)
  • Added .DS_Store into gitignored files
  • Added missing constants kHIDRemoteModeNone, kHIDRemoteModeShared to switch

smarek avatar Jun 19 '15 09:06 smarek

Thanks for the PR! I'd be happy to merge it in, but there is one small thing: the project unfortunately must remain GC-enabled in the repository. That's because Lion is supported, and Lion's System Preferences does not work non-GC prefpanes (as explained in the readme). Code is written in such fashion that it should behave correctly when compiled with either GC or ARC. Could you please revert it back to GC?

zsszatmari avatar Jun 19 '15 09:06 zsszatmari