com.zsmartsystems.zigbee icon indicating copy to clipboard operation
com.zsmartsystems.zigbee copied to clipboard

[WIP] execute autocode from maven

Open t-8ch opened this issue 5 years ago • 9 comments

As discussed in #527 . This is an early prototype to gather feedback. The commits are structured as follows:

  1. Delete all generated code, to make it easier to exclude from review
  2. Should probably be applied to master right away.
  3. The logic of the change.
  • Generated source code discovery works in IDEA, eclipse would have to be validated.

Caveats:

  • Currently only supports the base library. The dongle generation is possible as well. Maybe a dedicated mojo per project or via configurations, if they are similar enough.
  • Only maven (no gradle). Is there a reason for two build systems?
  • Executes the generation twice. (once triggered by the maven-source-plugin, may be disabled)

t-8ch avatar Feb 12 '19 18:02 t-8ch

Thanks @t-8ch . I've not looked over this yet as the changes are extensive. I assume that the real changes are only to the POM? Is it possible to leave the existing code included in the repo for now, or does this not work for some reason?

cdjackson avatar Feb 12 '19 19:02 cdjackson

I also note that the build seems to be failing (according the to LGTM CI anyway)...

cdjackson avatar Feb 12 '19 19:02 cdjackson

You should be able to ignore the first commit completely. I will take a look at the build.

t-8ch avatar Feb 12 '19 19:02 t-8ch

Ah, LGTM uses gradle. Is there an inherent reason for both build systems?

t-8ch avatar Feb 12 '19 19:02 t-8ch

Some systems needed to use gradle (some users needed it for Android).

On 12 Feb 2019, at 19:07, Thomas Weißschuh [email protected] wrote:

Ah, LGTM uses gradle. Is there an inherent reason for both build systems?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/zsmartsystems/com.zsmartsystems.zigbee/pull/531#issuecomment-462891812, or mute the thread https://github.com/notifications/unsubscribe-auth/AA_kQ1ZMk3qd4FCxZMJxzQBAklHsgaphks5vMxDjgaJpZM4a3v5k.

cdjackson avatar Feb 12 '19 19:02 cdjackson

Hm, shouldn't users only consume the .jar file? It shouldn't matter how it is generated.

t-8ch avatar Feb 12 '19 19:02 t-8ch

As said, this was required in some systems.

On 12 Feb 2019, at 19:19, Thomas Weißschuh [email protected] wrote:

Hm, shouldn't users only consume the .jar file? It shouldn't matter how it is generated.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/zsmartsystems/com.zsmartsystems.zigbee/pull/531#issuecomment-462896342, or mute the thread https://github.com/notifications/unsubscribe-auth/AA_kQ9G5VaYvdwVyEHFU7b6E7jPYxJzpks5vMxOmgaJpZM4a3v5k.

cdjackson avatar Feb 12 '19 19:02 cdjackson

I will see how it can support both

t-8ch avatar Feb 14 '19 13:02 t-8ch

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 06 '19 12:10 stale[bot]