hunt-and-peck icon indicating copy to clipboard operation
hunt-and-peck copied to clipboard

Define keyboard shortcuts on launch by XML file in %AppData%, and install with WiX

Open LawranceFung opened this issue 3 years ago • 21 comments

Installing HuntAndPeck and defining keyboard shortcuts in %AppData% seemed to go hand-in-hand since many applications do both, not just 1. If this makes more sense as 2 separate pull requests I can redo this as 2.
An MSI installer is much more intuitive for non-programmers. Someone who finds Vimium-style hints useful might experience significant confusion over a portable zipped application. Defining the keyboard shortcuts through XML is useful when they conflict with shortcuts for the active program, such as Visual Studio.

LawranceFung avatar Feb 21 '22 03:02 LawranceFung

Thank you very much, Lawrance!

sd309991 avatar Feb 23 '22 06:02 sd309991

Thank you very much, Lawrance!

No problem. This was a feature I had wanted to implement but hadn't gotten around to. ⎇; and ^; both conflict in visual studio.

LawranceFung avatar Feb 23 '22 09:02 LawranceFung

Thanks for raising this PR, really nice work!

Any idea what would need to change in https://github.com/zsims/hunt-and-peck/blob/master/src/build.cake ? (which is used in appveyor to make the build).

zsims avatar Feb 23 '22 09:02 zsims

Thanks for raising this PR, really nice work!

Any idea what would need to change in https://github.com/zsims/hunt-and-peck/blob/master/src/build.cake ? (which is used in appveyor to make the build).

Thanks! I have no idea what would be needed to change in cake. Cake has been deprecated so I would use another bootstrapper like WiX or InstallShield. I went with a WiX MSI because it's intuitive for most users, compared to a powershell or cake script.
I don't know anything about Appveyor either. I prefer Jenkins for CI/CD.

LawranceFung avatar Feb 23 '22 09:02 LawranceFung

I've worked on keyboard software before, so "Oem1" for semicolon didn't throw me off where it may distracted someone for long enough for some people to quit trying.

LawranceFung avatar Feb 23 '22 10:02 LawranceFung

Thanks, I'll look at fixing CI so we can spit an installer out.

zsims avatar Feb 28 '22 08:02 zsims

Sorry for the long delay landing this, I'm a bit strapped for time atm. The biggest thing is getting this working with CI (AppVeyor) to spit out an install

zsims avatar Mar 11 '22 09:03 zsims

Would it be possible to also save and load the hunt-and-peck configuration locally (same folder of the executable) for portable usages?

pidgeon777 avatar Mar 19 '22 17:03 pidgeon777

It's a bad idea to make it installable. Why install this?

liuxilu avatar Mar 22 '22 09:03 liuxilu

It's a bad idea to make it installable. Why install this?

You don't have to install it. Installation can help for deployment or may be preferred.

LawranceFung avatar Mar 22 '22 16:03 LawranceFung

~~Unzipping is the best deployment~~

liuxilu avatar Mar 23 '22 05:03 liuxilu

So if I understood correctly, placing the XML setting file in the same folder of the hunt-and-peck executable will be enough for loading and storing the configuration?

pidgeon777 avatar Mar 23 '22 08:03 pidgeon777

No. A portable settings provider implemention fyi: https://github.com/Bluegrams/SettingsProviders

liuxilu avatar Mar 23 '22 14:03 liuxilu

Sorry for the long delay landing this, I'm a bit strapped for time atm. The biggest thing is getting this working with CI (AppVeyor) to spit out an install

Is the CI piece still blocking this PR? If so, would it make sense to split this into separate PRs (one for the installer, one for keyboard shortcuts?

PS I only recently started using hunt-n-peck, but loving it so far. Thanks for building this!

weineran avatar May 04 '22 21:05 weineran

Hopefully, it will possible to define custom hotkeys for the actions and save the configuration.

Much better than manually starting the executable with the specific switch every time that an action is needed,

pidgeon777 avatar May 05 '22 07:05 pidgeon777

Sorry for the long delay landing this, I'm a bit strapped for time atm. The biggest thing is getting this working with CI (AppVeyor) to spit out an install

Is the CI piece still blocking this PR? If so, would it make sense to split this into separate PRs (one for the installer, one for keyboard shortcuts?

PS I only recently started using hunt-n-peck, but loving it so far. Thanks for building this!

C# defaults to different locations for a configuration file. It's pretty simple, but not quite as simple as cherry picking files/lines.

LawranceFung avatar May 06 '22 02:05 LawranceFung

Hopefully, it will possible to define custom hotkeys for the actions and save the configuration.

Much better than manually starting the executable with the specific switch every time that an action is needed,

If you really need it now, feel free to clone and compile my fork.

LawranceFung avatar May 06 '22 02:05 LawranceFung

If you really need it now, feel free to clone and compile my fork.

No, I don't need it now, but it would be a great addition to have in the future for sure 👍.

pidgeon777 avatar May 06 '22 10:05 pidgeon777

Any hopes of having this merged?

i-zanis avatar Sep 07 '22 13:09 i-zanis

I don't think this is gonna get merged now, just start providing releases on your fork OP.

jadedFella avatar Sep 16 '23 09:09 jadedFella