Django 2.0 compatibility

[jrd]

When using django 2.0, I got this: No module named 'django.core.urlresolvers' in markitup.templatetags.markitup_tags

[jrd]

The import should be from django.urls.

You can use try except ImportError scheme to be compatible…

It's in markitup_tags.py and widgets.py

[havrylenkok]

@zsiciarz please respond to #23 or #24 asap. Really anticipated fix.

[stefanor]

Or #21, which I filed before this ticket was opened :P

[zsiciarz]

Working on it! Sorry for the extremely late response, burnout is real. Hope to update django-markitup for Django 2.0 some time during next week.

[ivanvenosdel]

Glad to have you back @zsiciarz

[jrd]

Can I help to have this merged and released?

[dlancer]

Any progress with new release? Django 2.1 is already released, so would be nice to get new release with at least Django 1.11 and 2.0 support.

[ivanvenosdel]

@zsiciarz Any interest in authorizing someone to do PyPI releases or handing the whole project over to the jazzband?

[iraabbott]

FWIW: django 2.1 requires an additional change to two files. The patch mention previously (change reverse imports) gets rid of that '500' for 2.0, but with 2.1 there is another involving the 'render' kwarg being needed in the render routine.

in widgets.py: def render(self, name, value, attrs=None): changes to: def render(self, name, value, attrs=None, renderer=None):

twice at lines 14 and 71 in the latest on pypi as of this post.

Once I moved to local execution, fixed the url import and this fix, Bob was, indeed, my uncle.

This is explained in the very final line of the 2.1 release notes: Django 2.1 Release Notes

• Support for Widget.render() methods without the renderer argument is removed.

[dgilge]

Unfortunately, this issue is still not fixed. Does anybody have a (temporary) solution? For instance another package which is a continuation of this package?

[ivanvenosdel]

@dgilge As a permanent solution I ended up switching to django-markupfield and was able to automatically make a migration after switching the field type.

https://github.com/WimpyAnalytics/django-andablog/pull/59/commits/ddfdb036730cf6de0d01981e469143a54131d27a

[drnlm]

The CTPUG organisation has taken over maintaining django-markitup - https://github.com/CTPUG/django-markitup .

We've released django-markitup 3.5.0 with support for Django 2.0, and will continue working on the other outstanding issues.