zsh-syntax-highlighting icon indicating copy to clipboard operation
zsh-syntax-highlighting copied to clipboard

Published 20 hours ago • verified publisher icon zsh-users

zdharma performance optimizations

Open danielshahaf opened this issue 7 years ago • 10 comments

http://zdharma.org/posts/Fast-Syntax-Highlighting-Released https://github.com/zdharma/fast-syntax-highlighting [edit 20180523] http://www.zsh.org/cgi-bin/mla/redirect?USERNUMBER=23399

  • [x] Check license / permission to use that
  • [ ] Check if there's already a PR for these.
  • [ ] Review and cherry pick.

danielshahaf avatar Jun 03 '17 19:06 danielshahaf

The zdharma/fast-syntax-hightlighting/LICENSE is the same as in this project, even with exactly the same copyright notice. The license requires preserving the copyright and disclaimer, both items are already fulfilled.

maximbaz avatar Nov 22 '17 02:11 maximbaz

+1

Aeon avatar Jun 06 '18 17:06 Aeon

Looking at the copyright notices:

  • https://github.com/zdharma/fast-syntax-highlighting/blob/303eeee81859094385605f7c978801748d71056c/LICENSE#L1-L2
  • https://github.com/zdharma/fast-syntax-highlighting/blob/303eeee81859094385605f7c978801748d71056c/fast-syntax-highlighting.plugin.zsh#L1-L26
  • https://github.com/zdharma/fast-syntax-highlighting/blob/303eeee81859094385605f7c978801748d71056c/themes/q-jmnemonic.ini#L5-L7
  • https://github.com/zdharma/fast-syntax-highlighting/blob/303eeee81859094385605f7c978801748d71056c/themes/default.ini
  • https://github.com/zdharma/fast-syntax-highlighting/blob/303eeee81859094385605f7c978801748d71056c/:chroma/-autoload.ch#L2
  • https://github.com/zdharma/fast-syntax-highlighting/blob/303eeee81859094385605f7c978801748d71056c/:chroma/-subversion.ch#L2-L29

It's not clear to me under what license https://github.com/zdharma/fast-syntax-highlighting is under.

@psprint Would you be so kind as to clarify whether or not the z-sy-h project has permission to cherry-pick code from https://github.com/zdharma/fast-syntax-highlighting? What license is that repository under?

Cheers!

danielshahaf avatar Mar 20 '20 00:03 danielshahaf

Pinged again by email:

From: Daniel Shahaf
To: Sebastian Gniazdowski
Cc: Matthew Martin
Subject: Fw: [zsh-users/zsh-syntax-highlighting] zdharma performance  optimizations (#434)
Date: Sun, 29 Mar 2020 22:31:44 +0000
Message-ID: <[email protected]>

danielshahaf avatar Mar 29 '20 22:03 danielshahaf

For clarity: under copyright law, code may not be reused unless its author (as copyright holder) specifies otherwise. (It makes no difference that the code in question is public and derived from BSD-licensed code.) In our case, that means z-sy-h may not use any piece of code that's not explicitly stated to be BSD-licensed, barring specific permission from the author of the piece of code in question. Thus, the query to Sebastian regarding the license of the code he's distributing, and whether z-sy-h may use that code under a BSD license.

danielshahaf avatar Mar 29 '20 22:03 danielshahaf

Yes, you are allowed to reuse the code, the license is the same.

psprint avatar Mar 31 '20 14:03 psprint

Thanks, Sebastian!

danielshahaf avatar Mar 31 '20 23:03 danielshahaf

Folks — if there are particular features you'd like to propose to be cherry-picked, please file a new bug report for each such feature. (In order to avoid duplicates, please reference this issue #434 in the new bug reports.) Cheers!

danielshahaf avatar Mar 31 '20 23:03 danielshahaf

The "HSMW" prefix in the names of some variables, early in the history of fast-highlight in https://github.com/zdharma/fast-syntax-highlighting, refers to https://github.com/zdharma/history-search-multi-word.

danielshahaf avatar Apr 01 '20 02:04 danielshahaf

zdharma has moved here, the old project seems to have been taken down: https://github.com/zdharma-continuum/fast-syntax-highlighting

walles avatar Jan 07 '22 10:01 walles