zsh-syntax-highlighting icon indicating copy to clipboard operation
zsh-syntax-highlighting copied to clipboard

Published 20 hours ago • verified publisher icon zsh-users

highlight all available zsh glob pattern (not only * and ?)

Open m0vie opened this issue 9 years ago • 4 comments

Expansions are never analyzed for glob patterns to work around problems where complex constructs would wrongly be highlighted as glob patterns.

m0vie avatar Dec 31 '15 17:12 m0vie

First of all, this changeset fixes a bug whereby !* is highlighted as [globbing] rather than as [history-expansion].

Could you please write tests? The harness supports "expected failure" tests (printed in yellow/orange in the make test output) so you can also have tests for syntaxes you don't yet handle correctly. (And you can write tests for the behaviour you're adding and we can merge them before we actually merge the implementation of that behaviour.)

I'll have to read the new function more carefully.

danielshahaf avatar Dec 31 '15 18:12 danielshahaf

Updated the commit.

  • Moved glob check before redirect to be able to highlight patterns like <1-5>.
  • Fixed a typo for that check: <[0*9]*-[0-9]*> -> <[0-9]*-[0-9]*>
  • Added tests for all covered cases
  • Added two Xfail-tests for parameter expansions

m0vie avatar Apr 10 '16 11:04 m0vie

Rebased onto latest master for the changes to the tests.

m0vie avatar Apr 16 '16 16:04 m0vie

(Closing/reopening to trigger continuous integration)

nicoulaj avatar Aug 15 '17 10:08 nicoulaj