zsh-autosuggestions icon indicating copy to clipboard operation
zsh-autosuggestions copied to clipboard

formatting no longer cleared after completion if fg=7

Open xfnw opened this issue 2 years ago • 6 comments

Describe the bug

after updating to zsh 5.9, the color is no longer cleared after you complete something if you have ZSH_AUTOSUGGEST_HIGHLIGHT_STYLE="fg=7" set, however it works fine if set to 8

To Reproduce

Steps to reproduce the behavior:

  1. open zsh -df
  2. source zsh-autosuggestions
  3. type ZSH_AUTOSUGGEST_HIGHLIGHT_STYLE="fg=7" and hit enter
  4. type something and hit enter
  5. type the first letter and then press the right arrow key to accept the completion
  6. notice how the color stays, even if you continue typing

image

Expected behavior

it should clear the formatting after completing like it did on previous zsh versions

image

Desktop

  • OS + distribution: Arch Linux 2022-05-17
  • Zsh version: zsh 5.9 (x86_64-pc-linux-gnu)
  • Plugin version: a411ef3e0992d4839f0732ebeb9823024afaaaa8 (latest master at the time of writing)

xfnw avatar May 18 '22 01:05 xfnw

I'm experiencing something similar on mac; however it doesn't seem to be correct or fixed even as I vary my highlight style. On my side, if you type a single letter of the completion it changes the color to look like you've typed the whole thing.

image image

This started after I upgraded to MacOS 12.4. Details:

  • OS: macOS Monterey 12.4
  • Zsh version: zsh 5.8.1 (x86_64-apple-darwin21.0)
  • Plugin version: v0.7.0 - a411ef3e0992d4839f0732ebeb9823024afaaaa8

ryanb8 avatar May 26 '22 14:05 ryanb8

Having the same issue @ryanb8 have. Same config:

  • OS: macOS Monterey 12.4
  • zsh 5.8.1 (x86_64-apple-darwin21.0)
  • Plugin version: v0.7.0 - a411ef3e0992d4839f0732ebeb9823024afaaaa8
  • iTerm2 Build 3.4.15

alexandremjacques avatar May 28 '22 13:05 alexandremjacques

Having the same issue @ryanb8 have. Same config:

* OS: macOS Monterey 12.4

* zsh 5.8.1 (x86_64-apple-darwin21.0)

* Plugin version: v0.7.0 - [a411ef3](https://github.com/zsh-users/zsh-autosuggestions/commit/a411ef3e0992d4839f0732ebeb9823024afaaaa8)

* iTerm2 Build 3.4.15

Fixed by updating zsh-syntax-highlighting plugin (both are installed).

alexandremjacques avatar May 28 '22 13:05 alexandremjacques

Fixed by updating zsh-syntax-highlighting plugin (both are installed).

Does not work for me. Config:

  • macOS 12.4 (21F79) on Apple Silicon
  • zsh 5.9 (arm-apple-darwin21.3.0)
  • zsh-autosuggestions commit a411ef3
  • zsh-syntax-highlightning commit caa749d

stefanscheidt avatar May 29 '22 18:05 stefanscheidt

Same issues here (Updating zsh-syntax-highlighting won't fix)

  • Arch Linux
  • zsh 5.9 (x86_64-pc-linux-gnu)
  • zsh-autosuggestions commit a411ef3e099
  • zsh-syntax-highlighting commit b2c910a85

bekker avatar Dec 24 '22 08:12 bekker

#698 seems to be the same issue. The current version of zsh-autosuggestions and zsh 5.9 don't go well together. I had to set ZSH_AUTOSUGGEST_HIGHLIGHT_STYLE="fg=250" to make clearing work.

bekker avatar Dec 24 '22 08:12 bekker