lorca icon indicating copy to clipboard operation
lorca copied to clipboard

Gracefully quit the browser instance when Close is called

Open phanirithvij opened this issue 3 years ago • 2 comments

Can the browser be closed gracefully instead of quitting abruptly?

chromedp has it implemented

  • Issue https://github.com/chromedp/chromedp/issues/472
  • https://github.com/chromedp/chromedp/commit/c661502af30f396c892d1130af3fab7d73211faa
  • https://github.com/chromedp/chromedp/commit/3976e2ae9cebe027f6c2113e446627861aa5acef

I'm requesting it because the examples, when run with the same user-data-directory over multiple runs instead of using temporary ones and discarding each time, led to the following issue:

image

The second one opens saying chrome/browser crashed in the previous run.

phanirithvij avatar Jul 27 '21 15:07 phanirithvij

True, Lorca should do the same as WebUI. https://github.com/alifcommunity/webui

hassandraga avatar Jul 27 '21 22:07 hassandraga

fixed it by:

os.Remove("./tmp/Default/Preferences")

ui, err := lorca.New("", "./tmp", 480, 320, args...)

williamleecn avatar Nov 02 '21 20:11 williamleecn