stage-ci
stage-ci copied to clipboard
Docker deployments fail
Originally raised here.
The npm build
script isn't being run in Docker, it simply installs and then runs.
https://github.com/zpnk/stage-ci/blob/408f6a02a09b642b85ab92797c5646eabf1a6a72/package.json#L10
https://github.com/zpnk/stage-ci/blob/408f6a02a09b642b85ab92797c5646eabf1a6a72/Dockerfile#L7-L14
When now spins up a new deployment, it runs the build
step automatically.
I can see two ways to fix this:
- Update the Dockerfile to include the build step
- Rename the
build
script topreinstall
✌️
@zpnk ping?
I'm giving this a go now 👍
Fixed in #48 🐳