stage-ci icon indicating copy to clipboard operation
stage-ci copied to clipboard

Docker deployments fail

Open hugomd opened this issue 7 years ago • 3 comments

Originally raised here.

The npm build script isn't being run in Docker, it simply installs and then runs.

https://github.com/zpnk/stage-ci/blob/408f6a02a09b642b85ab92797c5646eabf1a6a72/package.json#L10

https://github.com/zpnk/stage-ci/blob/408f6a02a09b642b85ab92797c5646eabf1a6a72/Dockerfile#L7-L14

When now spins up a new deployment, it runs the build step automatically.

I can see two ways to fix this:

  1. Update the Dockerfile to include the build step
  2. Rename the build script to preinstall

✌️

hugomd avatar Nov 08 '17 22:11 hugomd

@zpnk ping?

imevro avatar Dec 20 '17 20:12 imevro

I'm giving this a go now 👍

hugomd avatar Jun 17 '18 08:06 hugomd

Fixed in #48 🐳

hugomd avatar Jun 21 '18 07:06 hugomd