building-react-from-scratch icon indicating copy to clipboard operation
building-react-from-scratch copied to clipboard

Is there something wrong with update method

Open amberonno opened this issue 7 years ago • 0 comments

in MultiChild.js file

case UPDATE_TYPES.MOVE: DOM.insertChildAfter( parentNode, parentNode.childNodes[fromIndex], update.afterNode, ); break; move method depends on 'fromIndex' (which is previous componet's _mountindex),which should be changed once some component insert before feels like that move method should rely on real DOM node, but not _mountindex

amberonno avatar Jan 03 '18 17:01 amberonno