crc32c icon indicating copy to clipboard operation
crc32c copied to clipboard

Why ARM hardware acceleration is guarded by nightly

Open lizhanhui opened this issue 1 year ago • 3 comments

Is there anything that blocks ARM hardware acceleration feature from being stable?

Will it be better to guard it using a feature?

lizhanhui avatar Nov 17 '23 11:11 lizhanhui

The crc32c intrinsics are still nightly only: https://doc.rust-lang.org/nightly/core/arch/aarch64/index.html

Tracking issue: https://github.com/rust-lang/rust/issues/117215

zowens avatar Mar 06 '24 19:03 zowens

This crate currently does not build on nightly on aarch64:

error[E0635]: unknown feature `stdarch_arm_crc32`
  --> /home/app/.cargo/registry/src/index.crates.io-6f17d22bba15001f/crc32c-0.6.5/src/lib.rs:23:60
   |
23 | #![cfg_attr(all(target_arch = "aarch64", nightly), feature(stdarch_arm_crc32))]
   |                                                            ^^^^^^^^^^^^^^^^^

For more information about this error, try `rustc --explain E0635`.
error: could not compile `crc32c` (lib) due to 1 previous error

jbg avatar May 19 '24 21:05 jbg

Looks like stdarch_arm_crc32 is stable in Rust 1.80!

See also https://github.com/srijs/rust-crc32fast/pull/36

shikhar avatar May 20 '24 14:05 shikhar

This is no longer guarded on nightly! If you are on the latest nightly or have rust 1.80 you should be good to go.

zowens avatar May 27 '24 17:05 zowens