zowe-cli
zowe-cli copied to clipboard
Token gets output to Imperative log in plain text
If trace level logging is enabled, the Imperative AbstractRestClient
logs the token value in plain text:
https://github.com/zowe/imperative/blob/44f5ca26991b9845500d4357bbb7a47b63b8db09/packages/rest/src/client/AbstractRestClient.ts#L446
@t1m0thyj, do we want to remove it from the trace level log?
If so, should this be a good first issue
?
@zFernand0 How do you suggest that we sanitize the token? I'm thinking something like this:
this.log.trace("Using cookie authentication with token type %s", this.session.ISession.tokenType);
I think that's good enough. However, Don't we want to deprecate tokenType and tokenValue? zowe/zowe-cli#1937
I added a comment to zowe/zowe-cli#1937 - but I'm wondering if we should not deprecate tokenType
without more discussion.