api-layer icon indicating copy to clipboard operation
api-layer copied to clipboard

chore: API Portal updates

Open pablocarle opened this issue 10 months ago • 5 comments

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Linked to # (issue) Part of the # (epic)

Type of change

Please delete options that are not relevant.

  • [ ] fix: Bug fix (non-breaking change which fixes an issue)
  • [ ] feat: New feature (non-breaking change which adds functionality)
  • [ ] docs: Change in a documentation
  • [ ] refactor: Refactor the code
  • [ ] chore: Chore, repository cleanup, updates the dependencies.
  • [ ] BREAKING CHANGE or !: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • [ ] My code follows the style guidelines of this project
  • [ ] PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • [ ] I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] The java tests in the area I was working on leverage @Nested annotations
  • [ ] Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

pablocarle avatar Apr 15 '24 16:04 pablocarle

Quality Gate Failed Quality Gate failed

Failed conditions 63.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

I will improve test coverage.

JanFilipMSD avatar Apr 16 '24 07:04 JanFilipMSD

The coverage needs to be increased

taban03 avatar Apr 19 '24 13:04 taban03

There is also a problem on the Zowe Catalog UI side. Although I am not sure whether this issue has been introduce before these changes, the swagger div width changes based on the service. Furthermore, when executing the request using "Try it out" functionality, the swagger panel width gets huge and the space between the responses code under "Response" is also big.

taban03 avatar Apr 19 '24 14:04 taban03

There is also another issue with the code snippets, only the tabs are visibile for me, and the response is not there anymore

taban03 avatar Apr 22 '24 11:04 taban03