textgrad.optimizer.optimizer_prompts.py lacks one argument for class TextualGradientDescentwithMomentum(Optimizer)

Open Zixind opened this issue 9 months ago • 1 comments

In class TextualGradientDescentwithMomentum(Optimizer): for def _update_prompt(self, variable: Variable, momentum_storage_idx: int): the function does not return anything. It needs to have "return prompt" otherwise in step(self), prompt_update_parameter = self._update_prompt(parameter, momentum_storage_idx=idx), prompt_update_parameter would be null.

Mar 04 '25 21:03 Zixind

yea we unfortunately never fixed this issue #96, would you have time to send a fix in a PR?

Mar 04 '25 22:03 vinid