translators icon indicating copy to clipboard operation
translators copied to clipboard

Update CNKI translator

Open l0o0 opened this issue 3 years ago • 11 comments

Sorry for the late.

Updates:

  1. expand URL matching for proxied URLs
  2. Zotero Connector parameters for Chinese names and CAJ/PDF attachment downloading
  3. Get citations and CSSCI

l0o0 avatar Sep 06 '21 11:09 l0o0

expand URL matching for proxied URLs

No, we don't do this — the Connector handles proxy detection, not individual translators. EZproxy installations should be automatically detected, and others can be configured manually in the Zotero Connector preferences (though not all proxy schemes are supported).

You'll need to revert the target change before we can accept this. All site-specific translators should have a target limited to a specific domain.

dstillman avatar Sep 07 '21 08:09 dstillman

expand URL matching for proxied URLs

No, we don't do this — the Connector handles proxy detection, not individual translators. EZproxy installations should be automatically detected, and others can be configured manually in the Zotero Connector preferences (though not all proxy schemes are supported).

You'll need to revert the target change before we can accept this. All site-specific translators should have a target limited to a specific domain.

OK, I will revert to the origin URL patent, also I will leave a comment if someone wants to expand the URL matching.

l0o0 avatar Sep 07 '21 11:09 l0o0

I will leave a comment if someone wants to expand the URL matching

What would it be expanded to? Are there domains that the original target should've matched but didn't?

AbeJellinek avatar Sep 10 '21 01:09 AbeJellinek

Oh, I see - if I understand correctly, the domain change was just for proxied URLs? In that case, I don't think a comment would be appropriate. Nobody should have to expand the target to match a proxy. If there's a proxy scheme that Zotero doesn't support, that's a separate issue and we should add support for it.

AbeJellinek avatar Sep 10 '21 01:09 AbeJellinek

Oh, I see - if I understand correctly, the domain change was just for proxied URLs? In that case, I don't think a comment would be appropriate. Nobody should have to expand the target to match a proxy. If there's a proxy scheme that Zotero doesn't support, that's a separate issue and we should add support for it.

Hi @AbeJellinek As I know, most colleges in China use EasyConnect for the proxy. Adding proxy in Zotero Connector can work in some cases. But some school uses dynamic proxy URL schema, it's hard to configure in Zotero Connector. Maybe expand the URL matching is the easiest way to work.

l0o0 avatar Sep 10 '21 07:09 l0o0

The problem is that the Connector's proxy support doesn't just determine whether to save — it also determines how the URL is saved. So if it doesn't detect it properly as a proxy, a proxied URL may be saved to the URL field (depending on the site), which wouldn't be appropriate for citation (or even future access) purposes.

dstillman avatar Sep 10 '21 08:09 dstillman

@l0o0: Could you give an example of a URL proxied by EasyConnect?

AbeJellinek avatar Sep 10 '21 18:09 AbeJellinek

@l0o0: Could you give an example of a URL proxied by EasyConnect?

These are proxied by URLs (from different colleges):

http://hfgga60aabc7d15084b00sqncnfnbuqv906uqp.fhaz.libproxy.ruc.edu.cn/kns8/defaultresult/index https://kns-cnki-net-s.vpn2.njau.edu.cn:8118/kcms/detail/detail.aspx?dbcode=CAPJ&dbname=CAPJDAY&filename=SPFX20210129001&v=%25mmd2Ff6t9sWdgG6X7m3%25mmd2FghP9ZI7zt%25mmd2Fchv0wCAVbQV7bAYNIfz45hIrJ%25mmd2FFK3HtcKcdU3N https://elksslcc0eb1c56d2d940cf2d0186445b0c858.casb.njucm.edu.cn/kns8/defaultresult/index http://kns-cnki-net-443--buaa.buaa.ilibs.cn/kns8/defaultresult/index https://kns-cnki-net-s.vpn.buaa.edu.cn:8118/kns8/defaultresult/index http://kns-cnki-net-s.vpn.cau.edu.cn:8118/kns8/defaultresult/index http://f3442d2d91cfa2485dde859ea753e903.3be401a9.libvpn.zuel.edu.cn/kns8/defaultresult/index https://er.szlib.org.cn/rwt/331/https/NNYHGLUDN3WXTLUPMW4A/kns8/defaultresult/index http://kns-cnki-net-s.vpn.ysu.edu.cn:8118/kcms/detail/detail.aspx?dbcode=CAPJ&dbname=CAPJDAY&filename=SHZN20210129001&v=UDLwfYA%25mmd2BHEE6A%25mmd2BqqSQyTOMdgNS%25mmd2FFL5DAA6GcomfOPuJdl4Qzpt7ZqbEl2SIzOVHQ https://kns-cnki-net-s.webvpn.scut.edu.cn/kns8/defaultresult/index https://kns-cnki-net-s.vpn3.fjnu.edu.cn/kns8/defaultresult/index https://v.guet.edu.cn/https/77726476706e69737468656265737421fbf952d2243e635930068cb8/kns8/defaultresult/index https://wvpn.upc.edu.cn/https/77726476706e69737468656265737421e7e056d2243e635930068cb8/?wrdrecordvisit=1612172555000 http://210.40.130.91/https/77726476706e69737468656265737421f3ff4fd228266d426d0d88e29b5b283c13d3673f/kns/defaultresult/index

Sometimes they use a dynamic prefix in the proxy schema, the prefix string of proxy URL will change when login in.

https://kns.cnki.net/kns8/defaultresult/index is CNKI search URL https://kns.cnki.net/kcms/detail/detail.aspx? is a article page URL

l0o0 avatar Sep 13 '21 05:09 l0o0

@AbeJellinek Hi, I've updated the URLs target and fixed the ESlint errors. But I don't know how to fix the left 4 errors.

l0o0 avatar Sep 19 '21 12:09 l0o0

@AbeJellinek Sorry for the mistake. I added another translator to this request. Now the wrong commit is deleted by force. Maybe is better to close this pull request and re-open a new one ?

l0o0 avatar Sep 21 '21 14:09 l0o0

Hi @AbeJellinek , someone suggests me to add citation in extra field in format like "24 CNKI". It's easy to find citation number and to sort item by extra file(sort by value of citation number). Is it OK to store value in this format instead of key value pairs ?

l0o0 avatar Dec 13 '21 02:12 l0o0

这开发者真是撩完就跑啊,没后续了。

skymagician avatar Mar 23 '23 15:03 skymagician

这开发者真是撩完就跑啊,没后续了。

I will create a new pull request in a few days. CNKI has update attachments download links,now you can download thesis PDF instead of caj.

l0o0 avatar Mar 23 '23 16:03 l0o0

这开发者真是撩完就跑啊,没后续了。

I will create a new pull request in a few days. CNKI has update attachments download links,now you can download thesis PDF instead of caj.

哈哈,你误会了,我说的不是你,是这个官方维护人员。之前主动找你说希望合并到官方库,提了合并请求之后就没后续了。

skymagician avatar Mar 23 '23 17:03 skymagician

@skymagician 😄知道你说的,这都多久的事了,居然还记得。官方这边的issue也挺多,而且国内数据库的细节比较多,我是能抓就抓,官方review比较花时间

l0o0 avatar Mar 23 '23 17:03 l0o0