django-bootstrap5 icon indicating copy to clipboard operation
django-bootstrap5 copied to clipboard

make addon_before_class and addon_after_class effective

Open phith0n opened this issue 2 years ago • 2 comments

addon_before_class and addon_after_class don't take effect as per its document:

        addon_before_class
            Class used on the span when ``addon_before`` is used.

            One of the following values:

                * ``'input-group-text'``
                * ``None``

            Set to None to disable the span inside the addon. (for use with buttons)

            :default: ``input-group-text``

        addon_after_class
            Class used on the span when ``addon_after`` is used.

            One of the following values:

                * ``'input-group-text'``
                * ``None``

            Set to None to disable the span inside the addon. (for use with buttons)

            :default: ``input-group-text``

So this PR added code for it.

phith0n avatar Jun 16 '22 20:06 phith0n

Pull Request Test Coverage Report for Build 2808049386

  • 5 of 6 (83.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 96.902%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/django_bootstrap5/renderers.py 5 6 83.33%
<!-- Total: 5 6
Totals Coverage Status
Change from base Build 2808047857: -0.2%
Covered Lines: 587
Relevant Lines: 601

💛 - Coveralls

coveralls avatar Aug 06 '22 05:08 coveralls

Thanks! Could you also add a unit test for this change?

dyve avatar Aug 06 '22 07:08 dyve

Thanks, we had 2 PR's for this one it seems. This was fixed in #361

dyve avatar Oct 15 '22 05:10 dyve

Thanks, we had 2 PR's for this one it seems. This was fixed in #361

Good job, thanks~

phith0n avatar Oct 15 '22 07:10 phith0n