django-bootstrap5 Added `.form-label` default to `<label>`s.

Added `.form-label` default to `<label>`s.

Open emmceemoore opened this issue 4 years ago • 6 comments

It looks like bootstrap 5 expects .form-label now on <label> elements.

TESTING:

Modified affected tests to reflect the newly added .form-label default.

Sep 26 '21 05:09 emmceemoore

Thanks, looks like we'll have to do quite a few fixes with all the breaking changes to forms.

Sep 26 '21 05:09 dyve

The label_class in render_label was intended for horizontal forms (which it seems is now obsolete).

I'll check the new changes and see what we need to do. Thanks for the PR, and I'll reply here later.

Sep 26 '21 05:09 dyve

For horizontal forms, we need col-form-label https://getbootstrap.com/docs/5.1/forms/layout/#horizontal-form

Sep 26 '21 07:09 dyve

Looks like this solution might be the only thing necessary after all, because most calls to render_label provide an explicit label_class. Still some checks to do, thanks for your patience.

Nov 01 '21 06:11 dyve

Any news on that? After upgrading several of my Django apps from BS4 to BS5, I became very much convinced, that I don't want to render forms myself anymore and should switch to django-bootstrapX. It would be really good, however, if all breaking changes are taken care of.