Zoran Kokeza

Thought that https://github.com/microsoft/TypeScript/pull/41994 might solve this issue, but just got the same error using it (maybe someone else wants to test it)

This is ready for review, if anyone has time to check. p.s. Sorry, it turned out to be a monster PR.

Hi @steve9164, just to check is this still interesting for Terria team to rebase the changes when I am free?

Won't this change cause more confusion? Data attribution for long time is not only for base maps but for all data available on the map. Also, if I recall correctly,...

Since #5167 all data that has attribution trait defined should have attribution value listed in the `Data attribution` (basemap) modal (it might happen that some of the attribution is not...

regarding ``` error TS2686: 'React' refers to a UMD global, but the current file is a module. Consider adding an import instead. ``` using react 17 named imports can't work...

Hi @MoRadwan74, @steve9164 Just to check, this will require all developers to implement RTL styling, and add a review point RTL styling. Have we considered using something like https://www.npmjs.com/package/stylis-plugin-rtl, it...

this is the current state |issue type |count| |------------------------------------------------------|-----| |@typescript-eslint/no-unused-vars |27 | |react-hooks/exhaustive-deps |16 | |@typescript-eslint/ban-ts-comment |11 | |react/display-name |8 | |no-constant-condition |3 | |@typescript-eslint/no-non-null-asserted-optional-chain|3 | |react/jsx-no-useless-fragment |2 | |react/jsx-key...

@steve9164 I have updated prettierignore to include more files

This is ready for review, added a basic conversion so no breaking changes are introduced in patch or minor version.